-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make smoke tests check recently added data deduplication feature #350
Make smoke tests check recently added data deduplication feature #350
Conversation
Some errors that should be returned as external error are being returned as fatal error. This caused a problem that was detected during Cadence integration. This commit resolves the problem by returning these fatal errors as external errors.
Some errors that should be returned as external error are being returned as fatal error. This caused a problem that was detected during Cadence integration. This commit resolves the problem by returning these fatal errors as external errors.
Cadence integration requires InlinedExtraData interface.
ContainerStorable interface supports encoding container storable (storable containing other storables) as element. This is needed for integration with Cadence.
This is needed for integration with Cadence because map key can be Cadence enums.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
We can maybe get this merged and discuss / address the comments in a follow-up (if needed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice addition to the stress test
Update for Cadence integration for atree inlining and deduplication
Closes #349
Updates epic #292 and issue #296
Currently, the data deduplication feature added by PR #342 is not being checked by smoke tests. We need to smoke test encoding/decoding to the new compact map format (which deduplicates nested Cadence composite types).
This PR adds nested composite types to smoke tests and checks encoding/decoding with the new compact map format to test data deduplication.
main
branchFiles changed
in the Github PR explorer